Skip to content

fix: reject code identifiers as credentials - #40

Merged
ppiankov merged 4 commits into
mainfrom
wo-390/code-identifier-precision
Jul 23, 2026
Merged

fix: reject code identifiers as credentials#40
ppiankov merged 4 commits into
mainfrom
wo-390/code-identifier-precision

Conversation

@ppiankov

Copy link
Copy Markdown
Owner

Summary

  • exclude lowercase calls, dotted references, and symbolic values from generic credential findings
  • preserve digit-bearing, provider-shaped, connection-string, and private-key detections
  • add focused regressions for Go, Python, and schema-label false positives

Test plan

  • swift test --filter DetectionRulesTests
  • swift test (1,067 tests)
  • swift build -c release
  • swiftlint lint --strict
  • git diff --check
  • dogfood the release binary against false-positive and literal fixtures

Work order: pastewatch/WO-390

ppiankov added 4 commits July 23, 2026 18:59
Caller-audit:
Sources/PastewatchCore/DetectionRules.swift:1169 -- updated credential validation uses value-shape classification
Caller-audit:
Sources/PastewatchCore/DetectionRules.swift:1201 -- updated bare-identifier evidence excludes parser option and local names
Caller-audit:
Sources/PastewatchCore/DetectionRules.swift:1201 -- updated evidence ordering preserves high-entropy credentials before source-name exclusions
@ppiankov
ppiankov merged commit 2d60efe into main Jul 23, 2026
7 checks passed
@ppiankov
ppiankov deleted the wo-390/code-identifier-precision branch July 23, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant